Skip to content

domains: fix handling of uncaught exceptions

Rodrigo Muino Tomonari requested to merge github/fork/misterdjules/fix-abort-on-uncaught-domain-error-handlers into master

Fix node exiting due to an exception being thrown rather than emitting an 'uncaughtException' event on the process object when:

  1. no error handler is set on the domain within which an error is thrown
  2. an 'uncaughtException' event listener is set on the process

Also fix an issue where the process would not abort in the proper function call if an error is thrown within a domain with no error handler and --abort-on-uncaught-exception is used.

Finally, change the behavior of --abort-on-uncaught-exception so that, if the domain within which the error is thrown has no error handler, but a domain further up the domains stack has one, the process will not abort.

Fixes #3607 (closed) and #3653 (closed).

Merge request reports