Skip to content

deps: V8: cherry-pick dfcdf7837e23

Rodrigo Muino Tomonari requested to merge github/fork/bcoe/fix-nullish into master

Coverage for nullish coalescing was broken in v8, and eating more characters than one would expect:

Screen Shot 2020-12-18 at 2 47 17 PM

This patch fixes it:

Screen Shot 2020-12-18 at 2 49 07 PM

Original commit message:

[coverage] fix greedy nullish coalescing

The SourceRangeScope helper was consuming too many characters, instead
explicitly create SourceRange, based on scanner position.

Bug: v8:11231
Change-Id: I852d211227abacf867e8f1ab3e3ab06dbdba2a9b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576006
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71765}

Refs: https://github.com/v8/v8/commit/dfcdf7837e23cc0da31f9b2d4211f856413d13af

Related Issues

Fixes: https://github.com/nodejs/node/issues/36619

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports

Loading