Skip to content

build: fix compiling against openssl with no-psk

Rodrigo Muino Tomonari requested to merge github/fork/everett1992/no-psk into master

fixes #36464 (closed)

Node 15 prior to this commit will not compile if openssl is built with no-psk. Compiling emits an error like this:

crypto_tls.cc:(.text+0x4c27): undefined reference to `node::crypto::TLSWrap::SetCACerts(node::crypto::SecureContext*)'

Blame on crypto_tls.cc shows the file was created in a refactor. Before that refactor SetCACerts was defined outside OPENSSL_NO_PSK ifndef

https://github.com/nodejs/node/blob/6751b6dc3da102f259b74b7453032edadc7a37ca/src/crypto/crypto_ssl.cc#L839

Merge request reports

Loading