Skip to content

fs: fix pre-aborted writeFile AbortSignal file leak

Rodrigo Muino Tomonari requested to merge github/fork/Linkgoron/fs-write-file-abort-signal-leak into master

This fixes an issue in promises.writeFile where a file is opened, and not closed if the abort signal is aborted before/during the file was opened.

A minor thing is that fd.close can still throw, I'm not sure if it's an issue or not.

In addition I also added validation for the AbortSignal, and a check where if the signal was already aborted, the file won't be opened at all.

  • [] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports