Skip to content

fs: fix writeFile AbortSignal does not close file

Rodrigo Muino Tomonari requested to merge github/fork/Linkgoron/fs-cb-signal-no-close into master

This PR fixes an issue where the callback-style writeFile does not close the fd when the AbortSignal is aborted (readFile handles this correctly).

I've also "optimized" the read-path to not open the file if the signal is aborted before the file is even opened.

(this PR is different than my other PR, which fixed an issue in promisified writeFile)

  • [] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [] tests and/or benchmarks are included
  • [] documentation is changed or added
  • commit message follows commit guidelines

Merge request reports