Skip to content

esm: consolidate ESM Loader methods

Rodrigo Muino Tomonari requested to merge github/fork/JakobJingleheimer/esm-consolidate-loader-hooks into master

closes #35524

Implements step 1 of #36396 (closed)

  • Consolidate loader hooks:
    • resolve = resolve [+getFormat]
    • load = getFormat + getSource + transformSource
    • globalPreload = getGlobalPreload
  • Consolidate node's internal default hooks:
    • new load (wrap existing get_format & get_source; delete transform_source)
    • resolve
  • Update when unknown format type (ERR_UNKNOWN_MODULE_FORMAT) is checked / thrown from after resolve to after load

For code changes:

  • Include tests for any bug fixes or new features.
  • Update documentation if relevant.
  • Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.
Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Merge request reports