Skip to content

deps: V8: cherry-pick 373f4ae739ee

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/torque into master

Original commit message:

[torque] Don't replace unmodified empty files

To improve incremental builds.

Bug: v8:7793
Change-Id: I6990a97e058d22d34acd1f609167cd30ca7518ad
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596789
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#72053}

Refs: https://github.com/v8/v8/commit/373f4ae739eeae0e4d2224b15002be35f1470312

Fixes: https://github.com/nodejs/node/issues/37368 Refs: https://github.com/nodejs/node/pull/36139#issuecomment-780739135

Some of the .inc files written by torque are empty, i.e. they are zero length. Actions in gyp generated makefiles are always run, and torque would always write out zero length files which meant their timestamps were newer than any previously compiled object file.

Merge request reports