Skip to content

net,tls: add abort signal support to connect

Rodrigo Muino Tomonari requested to merge github/fork/Linkgoron/net-tls-add-connect-abort-signal into master

A previous PR added support for AbortSignal to the net.Socket constructor and net.connect, however there was some missing documentation. I've added documentation (albeit minor) - I'd be happy for more suggestions if there are any other places that need it added, and also added tests for net.Socket and net.connect.

In addition, I've extended the AbortSignal support from net.Socket to tls.TLSSocket as it was a relatively minor change, and added tests for tls.connect, tls.TLSSocket, http2.connect and https.Agent.

There are https.Agent and https.request tests that fail without https://github.com/nodejs/node/pull/37730, so this PR is blocked on that one.

Merge request reports