Skip to content

src: indent long help text properly

Rodrigo Muino Tomonari requested to merge github/fork/glasser/wrapped-help-indentation into master

The previous code passed an ignored argument to StringPrototypeTrimLeft, and tried to trim a string that didn't start with whitespace. The trim makes more sense after the indentation has been added. Now wrapped lines actually show up with the rest of the help text.

This was a regression introduced in #36140.

Before:

  --frozen-intrinsics                    experimental frozen intrinsics support
  --heap-prof                            Start the V8 heap profiler on start up, and write the
  heap profile to disk before exit. If --heap-prof-dir is
  not specified, write the profile to the current working
  directory.
  --heap-prof-dir=...                    Directory where the V8 heap profiles generated by
  --heap-prof will be placed.

After:

  --frozen-intrinsics                    experimental frozen intrinsics support
  --heap-prof                            Start the V8 heap profiler on start up, and write the
                                         heap profile to disk before exit. If --heap-prof-dir is
                                         not specified, write the profile to the current working
                                         directory.
  --heap-prof-dir=...                    Directory where the V8 heap profiles generated by
                                         --heap-prof will be placed.

Doing this made an uncharacteristic trailing newline in the --icu-data-dir help text more obvious, so I removed that.

Merge request reports