Skip to content

src: remove KeyObjectData::CreateSecret overload

Rodrigo Muino Tomonari requested to merge github/fork/tniessen/src-remove-keyobjectdata-createsecret-arraybufferorviewcontents into master

This function is unused and there is not much potential for using it in the current codebase.

This is the only invocation of CreateSecret that could use this overload instead of calling ToCopy, and it seems appropriate to explicitly call ToCopy here.

https://github.com/nodejs/node/blob/f562ec64e8e3d602fb5035c079c97fff59c395cd/src/crypto/crypto_keys.cc#L946-L950

Merge request reports