Skip to content

deps,debugger: move node-inspect into core

Rodrigo Muino Tomonari requested to merge github/fork/Trott/node-inspect into master

Refs: https://github.com/nodejs/node/discussions/36481

I named a lot of files/directories with inspector-cli and I suspect inspect-cli or debugger-cli (or just debugger or inspect) would have all been better?

Still some ESLint checks to re-enable in three files, but assuming tests pass everywhere, I think this is good enough to land and things can be adjusted with subsequent PRs.

Because I was porting over the tests, this found and fixed a small bug with node inspect in Node.js 15.x. Specifically, calling scripts would always include internal scripts, even with scripts(false). (Wouldn't mind reconsidering that API as that first argument is a boolean trap. But OMG not when first landing this thing.)

Also there are some changes that landed in the node-inspect repo but never made it into a release. Those changes will need to be ported over. But that's the next PR. (Or maybe the lint fixes would be the next one.)

Merge request reports