Skip to content

[v10.x backport] fs: validate fds as int32s

Rodrigo Muino Tomonari requested to merge github/fork/Ayase-252/backport-28984-to-v10.x into v10.x-staging

Original Commit

This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: https://github.com/nodejs/node/pull/28984
Fixes: https://github.com/nodejs/node/issues/28980
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Fixes: https://github.com/nodejs/node/issues/37912 Fixes: https://github.com/nodejs/node/issues/38092 Fixes: https://github.com/nodejs/node/issues/38193

Merge request reports