Skip to content

build: sync generation of `v8_build_config.json`

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/d8 into master

The contents of the v8_build_config.json file generated when configured with --enable-d8 is missing entries which prevent V8's test runner from using the built d8 binary. Sync the keys written into the file with those generated in V8's deps/v8/BUILD.gn file.

Prior to this patch V8's test runner would fail to parse v8_build_config.json as it was missing v8_control_flow_integrity:

$ python2 deps/v8/tools/run-tests.py --outdir ../../out/Release --progress=dots --timeout=120 mjsunit debugger message preparser
Traceback (most recent call last):
  File "/home/rlau/sandbox/github/node/deps/v8/tools/testrunner/base_runner.py", line 283, in execute
    self._load_build_config(options)
  File "/home/rlau/sandbox/github/node/deps/v8/tools/testrunner/base_runner.py", line 428, in _load_build_config
    self.build_config = _do_load_build_config(outdir, options.verbose)
  File "/home/rlau/sandbox/github/node/deps/v8/tools/testrunner/base_runner.py", line 253, in _do_load_build_config
    return BuildConfig(build_config_json)
  File "/home/rlau/sandbox/github/node/deps/v8/tools/testrunner/base_runner.py", line 173, in __init__
    self.control_flow_integrity = build_config['v8_control_flow_integrity']
KeyError: 'v8_control_flow_integrity'

Merge request reports