Skip to content

build: make build-addons errors fail the build

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/addon-verify into master

The build-addons makefile target runs tools/doc/addon-verify.js and then uses touch to update a timestamp file. Unconditionally calling touch was losing the exit code from tools/doc/addon-verify.js so any errors produced by that script were not failing the build.

Refs: https://github.com/nodejs/node/pull/38966#issuecomment-857741107

Merge request reports