Skip to content

errors: remove source map rekey logic

Rodrigo Muino Tomonari requested to merge github/fork/bcoe/38945 into master

The rekeying logic no longer seems to be necessary to ensure that source maps are written to disk before the application exits.

Fixes #38945 (closed)

I believe improvements could be made to both this class of error and to the error described in #39017, such that we try to still annotate the stack trace with the original call site. But, in both cases, I think it's good to land the obvious fix initially.

What we ultimately lose with source-maps enabled is the syntactic sugar of:

/Users/bencoe/oss/node-1/test/fixtures/source-map/throw-string.js:1
function Hello(){throw"goodbye"}Hello();
                 ^

Which I don't think is standard stack trace output any ways.

Merge request reports