Skip to content

[v14.x] deps: restore minimum ICU version to 65

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/v14.x-icu into v14.x-staging

This modifies 40df0dcb so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67.

The minimum ICU version was bumped to 67 in Node.js 14.6.0 by https://github.com/nodejs/node/pull/34356 but the referenced V8 commit[1] isn't on v14.x-staging and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65.

[1] https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46 [2] https://github.com/v8/v8/commit/eeccedee1882f1f870b37d12978cd818934b375d

Refs: https://github.com/nodejs/node/pull/38178#issuecomment-863116223

I've tested this in a Fedora 32 container with

  • ./configure --with-intl=system-icu (system ICU 65)
  • ./configure (ICU 69 in the Node.js source tree)

make test passes with both configurations.

A wider discussion regarding ICU upgrade policy within a release line is happening in https://github.com/nodejs/Release/issues/679.

cc @nodejs/releasers @AdamMajer

Merge request reports