Skip to content

[v14.x] deps: V8: cherry-pick 81181a8ad80a

Rodrigo Muino Tomonari requested to merge github/fork/thomasmichaelwallace/v14.x-staging into v14.x-staging

Original commit message:

[JSON] Fix GC issue in BuildJsonObject
We must ensure that the sweeper is not running or has already swept
mutable_double_buffer. Otherwise the GC can add it to the free list.

Bug: v8:11837
Change-Id: Ifd9cf15f1c94f664fd6489c70bb38b59730cdd78
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928181
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74859}

Refs: v8/v8@81181a8

Fixes: #37553 (closed)

Sorry if I've got this wrong; I've tried to follow the v8 patch contribution guidelines, but this is my first time and C++ is not my best language 😄

Some additional context:

  • this is an v8 fix for a bug causing failure on AWS lambda (which tracks node 14)
  • therefore I think it's a good candidate for a backport
  • this fix was backported in v8 from master to v9.2.230.13 (https://chromium-review.googlesource.com/c/v8/v8/+/2988414)
  • if I understand correctly, this means the fix hasn't hit node 16, but it will be picked up in time because node 16 is tracking v8 9.2.X
  • the node 14 v8 code has diverged enough that I had to apply this patch manually (which was easy, given how small it is!)

Merge request reports