Skip to content

win,msi: use localized "Authenticated Users" name

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/msbuild into master

Well known user account names are localized on Windows. Look up the "Authenticated Users" user by its security identifier to get the localized name.

Refs: https://github.com/nodejs/node/commit/e817ba70f56c4bfd5d4a68dce8b165142312e7b6 Refs: https://hackerone.com/reports/1211160 Fixes: https://github.com/nodejs/node/issues/39224

cc @kumarak @nodejs/platform-windows

I think this will work, but I'm running on English Windows 10 so wasn't seeing the error reported on non-English locales. I'm going to build a test build so people can try out the installer.

Merge request reports