Skip to content

build: add `library_files` to gyp variables

Rodrigo Muino Tomonari requested to merge github/fork/himself65/20210707-support-py3 into master

GYP uses the system path when parsing node.gyp; however, if system python is different from our gyp runtime python, like '2.7', gyp would crash.

➜  node git:(master) ./configure && /usr/bin/python3 tools/gyp_node.py -f make 
Node.js configure: Found Python 3.9.6...
INFO: configure completed successfully
Traceback (most recent call last):
  File "tools/search_files.py", line 22, in <module>
    main()
  File "tools/search_files.py", line 19, in main
    print('\n'.join(utils.SearchFiles(options.directory, options.ext)))
  File "/Users/himself65/Code/Github/node/tools/utils.py", line 112, in SearchFiles
    list = glob.glob(dir+ '/**/*.' + ext, recursive=True)
TypeError: glob() got an unexpected keyword argument 'recursive'
gyp: Call to 'python tools/search_files.py --ext js lib' returned exit status 1 while in /Users/himself65/Code/Github/node/node.gyp.

Upstream: https://github.com/nodejs/node/pull/39069

Merge request reports