Skip to content

http: decodes url.username and url.password for authorization header

Rodrigo Muino Tomonari requested to merge github/fork/lewgordon/fix-url-username-decoding into master

This change properly decodes the url.username and url.password for the authorization header constructed from the URL object for http(s) requests.

Fixes: https://github.com/nodejs/node/issues/31439

NOTE: I am aware of @addaleax's work in her other PR. I'm definitely willing to give credit where credit is due. Mainly I'd just like to see this issue be fixed in one way or another.

Tested locally with make -j4 test.

Merge request reports