Skip to content

src: close HandleWraps instead of deleting them in OnGCCollect()

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/39036-dev into master

When all strong BaseObjectPtrs to a HandleWrap are gone, we should not delete the HandleWrap outright, but instead close it and then delete it only once the libuv close callback has been called.

Based on the valgrind output from the issue below, this has a good chance of fixing it.

Fixes: https://github.com/nodejs/node/issues/39036

Merge request reports