Skip to content

buffer: Default to UTF8 in JS rather than C++

Rodrigo Muino Tomonari requested to merge github/fork/tomgco/fast-buf into master

This will cause a minor speedup as previously with undefined values we would always cast to a string and then proceed to call .toLowerCase()

screenshot from 2015-11-24 22-37-39 screenshot from 2015-11-24 22-38-04

First flame-graph is before, second is after; calls to ToLowerCase() are highlighted in purple.

Tests seems to pass, but wanted to make sure that this is a safe change.

Merge request reports

Loading