Skip to content

dgram: fix send with out of bounds offset + length

Rodrigo Muino Tomonari requested to merge github/fork/Linkgoron/dgram-fix-str-with-len into master

fix Socket.prototype.send sending garbage when the message is a string, and offset+length is out of bounds.

When a string message was sent with offset/length, the underlying buffer from Buffer.from was sent without checking the original string's length, and garbage was sent if length/offset were too long. Instead, the method now throws an ERR_OUT_OF_RANGE ERR_BUFFER_OUT_OF_BOUNDS error.

Edit: Also added checks for Buffers

Fixes: #40491 (closed)

Merge request reports