Skip to content

[v14.x] build: pin build-docs workflow to Node.js 14

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/workflow-v14.x into v14.x-staging

The build-docs workflow runs tests which means it is sensitive to globals and can fail if the node running the test has a different set of globals to that expected by test/common.

e.g failure on current v14.x-staging https://github.com/nodejs/node/runs/4301335343?check_suite_focus=true

=== release test-apilinks ===
Path: doctool/test-apilinks
Error: --- stderr ---
node:assert:171
  throw err;
  ^

AssertionError [ERR_ASSERTION]: Unexpected global(s) found: performance
    at process.<anonymous> (/home/runner/work/node/node/test/common/index.js:302:14)
    at process.emit (node:events:402:35) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: undefined,
  operator: 'fail'
}
Command: /opt/hostedtoolcache/node/16.13.0/x64/bin/node /home/runner/work/node/node/test/doctool/test-apilinks.mjs

compare to https://github.com/nodejs/node/blob/0682370d9c988f2ae2846eb4f12727e8450e202b/test/common/index.js#L253-L262

Merge request reports