Skip to content

net: add new options to `net.Socket` and `net.Server`

Rodrigo Muino Tomonari requested to merge github/fork/ShogunPanda/net-socket-options into master

Hello! This PR adds the new following options to net.Socket.connect:

  • noDelay (boolean): If set to true, calls uv_tcp_nodelay on the socket after connection. By default it is disabled.
  • keepAlive (boolean) and keepAliveDelay (number): If set to true calls uv_tcp_nodelay on the socket after connection. By default it is disabled.

This changes are needed as preliminary work on #34185 (closed) to avoid excessive JS to C++ bridging. As I'm not a C++ expert, I encountered the following problems:

  1. Not sure how to test changes (even though test suite is passing so apparently nothing is broken)
  2. Error handling in TCPWrap::AfterConnect was tentative so some C++ expert should take a look. Moreover, what shall we do if uv_tcp_connect succeeds but any of uv_tcp_nodelay or uv_tcp_keepalive fails? Shall we close the socket or let user handle it? Currently I don't do anything.

Once this is initially reviewed, I will also add (either here or in a new PR) the analogous on inbound connections.

Merge request reports