Skip to content

crypto: prettify othername in PrintGeneralName

Rodrigo Muino Tomonari requested to merge github/fork/tniessen/crypto-othername-format into master

This change switches from the format produced by i2v_GENERAL_NAME to the format produced by GENERAL_NAME_print for GEN_OTHERNAME entries. This effectively produces entries of the form othername:SRVName:example.com instead of othername: SRVName::example.com. This is more consistent with other GENERIC_NAME entries and produces less awkward values in the legacy object representation.

(Please take a look at the modified test file to see the effect.)

This addresses the following TODO:

https://github.com/nodejs/node/blob/626367c4e3b57dab3e6c1e9926cc24e2d662e14a/src/crypto/crypto_common.cc#L798-L802

I also consider this the last major change required to resolve this TODO:

https://github.com/nodejs/node/blob/626367c4e3b57dab3e6c1e9926cc24e2d662e14a/src/crypto/crypto_common.cc#L726

Refs: https://github.com/nodejs/node/commit/466e5415a2b7b3574ab5403acb87e89a94a980d1

Merge request reports