Skip to content

inspector: set sampling interval before start

Rodrigo Muino Tomonari requested to merge github/fork/codebytere/switch-profiler-order into main

Fixes an issue seen in CPU profiling tests:

Receive CPU profile message
{"id":3,"error":{"code":-32000,"message":"Cannot change sampling interval when profiling."}}

which is the result of calling Profiler.setSamplingInterval after calling Profiler.start. V8 explicitly disallows this.

Merge request reports