Skip to content

child_process: fix setSimultaneousAccepts

Rodrigo Muino Tomonari requested to merge github/fork/theanarkh/fix_setSimultaneousAccepts into main

The error from CI is as follows. When pass the pipe handle by IPC on win32, the bug will be triggered because setSimultaneousAccepts is only defined on tcp handle. In addition, setSimultaneousAccepts should only be valid on tcp server.

error Message
fail (1)
Stacktrace
node:internal/child_process:821
        handle.setSimultaneousAccepts(true);
               ^

TypeError: handle.setSimultaneousAccepts is not a function
    at target._send (node:internal/child_process:821:16)
    at target.send (node:internal/child_process:738:19)
    at sendHelper (node:internal/cluster/utils:28:15)
    at RoundRobinHandle.handoff (node:internal/cluster/round_robin_handle:128:3)
    at RoundRobinHandle.distribute (node:internal/cluster/round_robin_handle:108:10)
    at handle.onconnection (node:internal/cluster/round_robin_handle:45:54)
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports