Skip to content

src: return void in InitializeInspector()

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/ignore-initializer-code into main

We have been ignoring inspector port binding errors during startup. Handling this error would be a breaking change and it's probably surprising to refuse to launch the Node.js instance simply because the inspector cannot listen to the port anyway. So just turn the return value of InitializeInspector() void and remove the TODOs for handling the error.

(I have a different branch at https://github.com/joyeecheung/node/tree/inspector-code that actually handles the error, but TBH I find that behavior to be a bit surprising when I play around with it locally, so I've decided to open this PR instead.)

Merge request reports