Skip to content

No call to SetIdle() when terminating

Rodrigo Muino Tomonari requested to merge github/fork/ywave620/no-SetIdle-when-terminating into main

Fix https://github.com/nodejs/node/issues/45421, where you can find a helpful stack trace

One can argues that v8 is responsable for transfering vm state to EXTERNAL before invoking PerIsolateMessageListener(), if v8 agrees and changes for it, this issue is gone without any change of Node.js. However, SetIdle() is basically for cpu profiling only, it's not necessary when terminating. Removing it is not harmful while otherwise will lead to crash before v8 makes that change.

Merge request reports