Skip to content

deps: V8: cherry-pick 9df5ef70ff18

Rodrigo Muino Tomonari requested to merge github/fork/anonrig/deps/v8-wasdetached into main

Original commit message:

Add an `v8::ArrayBuffer::WasDetached` method to the C++ API

V8's C++ API does not give a way to tell whether an ArrayBuffer has
been detached from the `v8::ArrayBuffer` class. In fact, as far as can
be told from the C++ API without running JS code, detached
ArrayBuffers behave the same as zero-sized ArrayBuffers and there is
no way to observe the difference. However, this difference can be
observed in JS because constructing a TypedArray from a detached
ArrayBuffer will throw.

This change adds a `WasDetached` method to the `v8::ArrayBuffer` class
to give embedders access to this information without having to run JS
code.

Bug: v8:13159
Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83963}

Refs: https://github.com/v8/v8/commit/9df5ef70ff18977b157028fc55ced5af4bcee535

Merge request reports