Skip to content

Fix: subprocess call to generate.py

Rodrigo Muino Tomonari requested to merge github/fork/nishantsikarwar/develop into main

subprocess.run uses a default of check=False, which means that a nonzero exit code will be ignored by default, instead of raising an exception. here

https://github.com/nodejs/node/blob/f6e402edfc4d872447009201feee1c0e41931f22/deps/v8/tools/builtins-pgo/generate.py#L45

Merge request reports

Loading