Skip to content

deps: backport 066747e from upstream V8

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/fix-3538 into v5.x

This backport fixes a performance pathology in how arrays grow/shrink. This was a regression introduced in V8 4.5. The V8 team has already backported this a far back as V8 4.7. We need to float the backport for v5.x (V8 4.6) and v4.x (V8 4.5).

Fixes: https://github.com/nodejs/node/issues/3538 V8-Commit: https://github.com/v8/v8/commit/066747ea053012a99e0cd3e20f36b8ed053b2124

Original commit message: Make sure that NormalizeElements and ShouldConvertToFastElements are …

…based on the same values

BUG=v8:4518 LOG=n

Review URL: https://codereview.chromium.org/1472293002

Cr-Commit-Position: refs/heads/master@{#32265 (closed)}

Merge request reports

Loading