Skip to content

win,src: revert simdutf to icu for win arm64

Recently, there has been a huge increase in the failing test count in Node.js on Windows on ARM64. One of the runs showcasing that can be viewed here. After investigating, I discovered that those failures are caused by migration from icu to simdutf. This PR reverts those changes for Windows on ARM, thus eliminating the regression.

There is an active effort, which I'm a part of, working on adding Windows on ARM to the list of officially supported platforms (adding it to CI, etc.). Once that's done, all changes will be tested there and we'll be able to see regressions earlier while still in PR. I've also opened an issue upstream in the simdutf repo to discuss it and find an appropriate solution.

cc: @nodejs/platform-windows-arm, @anonrig

Refs: https://github.com/nodejs/build/issues/3046 Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/pull/46471 Refs: https://github.com/nodejs/node/pull/46472 Refs: https://github.com/nodejs/node/pull/46548 Refs: https://github.com/simdutf/simdutf/issues/216

Merge request reports

Loading