Skip to content

src: fail CommonEnvironmentSetup if environment bootstrapping failed

Rodrigo Muino Tomonari requested to merge github/fork/legendecas/bootstrap-exception into main

If the Environment is failed to bootstrap at development time (e.g. syntax errors or uncaught exceptions in the JavaScript bootstrapping codes), the CommonEnvironmentSetup::CreateForSnapshotting should return a nullptr instead of a CommonEnvironmentSetup with a nullptr env member, which would lead to invalid access.

Unfortunately, I'm not aware of a method to run an unhappy path in bootstrapping to add a test case for this behavior.

Merge request reports