Skip to content

src: slim down stream_base-inl.h

Rodrigo Muino Tomonari requested to merge github/fork/lilsweetcaligula/bug43712-stream_base into main

De-inline and move big functions from stream_base-inl.h to reduce the binary size by 4 bytes in 9/10 compilations.

Other method definitions were tested (notably StreamResource::PushStreamListener), however I empirically verified (via compiling multiple times) that moving those increased the binary size, hence I left them alone.

Non-functional change.

Refs: https://github.com/nodejs/node/issues/43712

P.S. Special thanks to @kvakil for posting the SQLite3 database which I in part relied upon to make the decisions.

Merge request reports