Skip to content

crypto: remove obsolete SSL_OP_* constants

Rodrigo Muino Tomonari requested to merge github/fork/tniessen/crypto-remove-useless-ossl-constants into main

None of these constants have any effect in recent OpenSSL versions, not even in Node.js release lines that still use OpenSSL 1.1.1.

It is likely rare that these options are still used (intentionally), and removing them is unlikely to break any existing applications. These constants can only be passed to the secureOptions option of tls.createSecureContext() and related APIs, and a value of undefined will be ignored. Similarly, if a bitwise combination of multiple options is used, undefined constants will not change the behavior because (a | undefined | b) === (a | b) for (small) integers a and b.

(For once, JavaScript's oddities work in our favor.)

Thus, I am again suggesting to skip any deprecation cycle. cc @nodejs/tsc due to https://github.com/nodejs/node/labels/semver-major

Refs: https://github.com/nodejs/node/pull/46954 Refs: https://github.com/nodejs/node/pull/47066

Merge request reports