Skip to content

lib,src: replace toUSVString with `toWellFormed()`

Rodrigo Muino Tomonari requested to merge github/fork/anonrig/to-usv-string-to-well-formed into main

Fixes https://github.com/nodejs/node/issues/47328, depends on V8 11.3

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1315/

url/url-searchparams-creation.js n=1000000 inputType='iterable' type='array'                                           ***     13.84 %       ±2.92%  ±3.89%  ±5.06%
url/url-searchparams-creation.js n=1000000 inputType='iterable' type='encodelast'                                      ***     37.48 %       ±3.82%  ±5.10%  ±6.68%
url/url-searchparams-creation.js n=1000000 inputType='iterable' type='encodemany'                                      ***     40.92 %       ±3.38%  ±4.52%  ±5.93%
url/url-searchparams-creation.js n=1000000 inputType='iterable' type='multiprimitives'                                 ***     34.02 %       ±3.20%  ±4.26%  ±5.54%
url/url-searchparams-creation.js n=1000000 inputType='iterable' type='noencode'                                        ***     35.28 %       ±3.22%  ±4.28%  ±5.59%
url/url-searchparams-creation.js n=1000000 inputType='object' type='array'                                              **      5.75 %       ±3.45%  ±4.61%  ±6.05%
url/url-searchparams-creation.js n=1000000 inputType='object' type='encodelast'                                        ***     17.50 %       ±2.83%  ±3.77%  ±4.91%
url/url-searchparams-creation.js n=1000000 inputType='object' type='encodemany'                                        ***     16.51 %       ±3.34%  ±4.44%  ±5.78%
url/url-searchparams-creation.js n=1000000 inputType='object' type='multiprimitives'                                   ***     17.07 %       ±2.93%  ±3.90%  ±5.08%
url/url-searchparams-creation.js n=1000000 inputType='object' type='noencode'                                          ***     13.41 %       ±3.73%  ±4.99%  ±6.54%
url/url-searchparams-creation.js n=1000000 inputType='string' type='array'                                             ***      6.40 %       ±3.43%  ±4.57%  ±5.95%
url/url-searchparams-creation.js n=1000000 inputType='string' type='encodelast'                                        ***      7.34 %       ±3.07%  ±4.09%  ±5.32%
url/url-searchparams-creation.js n=1000000 inputType='string' type='encodemany'                                        ***      7.22 %       ±3.63%  ±4.83%  ±6.28%
url/url-searchparams-creation.js n=1000000 inputType='string' type='multiprimitives'                                   ***      8.62 %       ±3.06%  ±4.07%  ±5.30%
url/url-searchparams-creation.js n=1000000 inputType='string' type='noencode'                                          ***      7.33 %       ±3.08%  ±4.10%  ±5.34%
url/url-searchparams-iteration.js n=1000000 loopMethod='forEach'                                                               -2.47 %       ±6.73%  ±8.97% ±11.71%
url/url-searchparams-iteration.js n=1000000 loopMethod='iterator'                                                               0.13 %       ±3.97%  ±5.29%  ±6.88%
url/url-searchparams-read.js n=20000000 param='nonexistent' accessMethod='get'                                         ***     40.19 %       ±3.18%  ±4.25%  ±5.56%
url/url-searchparams-read.js n=20000000 param='nonexistent' accessMethod='getAll'                                      ***     49.89 %       ±3.43%  ±4.57%  ±5.97%
url/url-searchparams-read.js n=20000000 param='nonexistent' accessMethod='has'                                         ***     60.54 %       ±3.37%  ±4.51%  ±5.93%
url/url-searchparams-read.js n=20000000 param='one' accessMethod='get'                                                 ***     78.13 %       ±3.68%  ±4.93%  ±6.51%
url/url-searchparams-read.js n=20000000 param='one' accessMethod='getAll'                                              ***     23.62 %       ±2.74%  ±3.64%  ±4.74%
url/url-searchparams-read.js n=20000000 param='one' accessMethod='has'                                                 ***     84.82 %       ±4.26%  ±5.71%  ±7.50%
url/url-searchparams-read.js n=20000000 param='three' accessMethod='get'                                               ***     72.78 %       ±4.67%  ±6.21%  ±8.08%
url/url-searchparams-read.js n=20000000 param='three' accessMethod='getAll'                                            ***     25.17 %       ±2.42%  ±3.23%  ±4.23%
url/url-searchparams-read.js n=20000000 param='three' accessMethod='has'                                               ***     70.79 %       ±4.05%  ±5.43%  ±7.16%
url/url-searchparams-read.js n=20000000 param='two' accessMethod='get'                                                 ***     65.16 %       ±4.96%  ±6.61%  ±8.63%
url/url-searchparams-read.js n=20000000 param='two' accessMethod='getAll'                                              ***     26.08 %       ±3.88%  ±5.22%  ±6.89%
url/url-searchparams-read.js n=20000000 param='two' accessMethod='has'                                                 ***     60.99 %       ±2.14%  ±2.85%  ±3.72%

Merge request reports