Skip to content

crypto: replace THROW with CHECK for scrypt keylen

Rodrigo Muino Tomonari requested to merge github/fork/tniessen/crypto-scrypt-keylen-check into main

The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure that the keylen argument fits into a signed 32-bit integer, thus, the THROW statement in C++ is unreachable (unless the binding is accessed directly, of course).

https://github.com/nodejs/node/blob/af8ed0206732319c63a86ecb54d2588b953d45f2/lib/internal/crypto/scrypt.js#L85-L91

Merge request reports