Skip to content

deps: add minimatch as a dependency

Rodrigo Muino Tomonari requested to merge github/fork/MoLow/add-minimatch-as-dep into main

Refs: https://github.com/nodejs/node/pull/47490 Refs: https://github.com/nodejs/node/pull/47486

TLDR of the discussions in those two PRs is:

  • it does not make much sense to re-implement glob matching in core, minimatch is a battlefield-tested solution for this.
  • exposing minimatch as-is via fs.glob or path.glob has many issues (doesn't use primordials, doesn't use node's built-in errors, its API might change, it is not bound to node's semver)

this PR adds minimatch as a dependency with the desire to currently only use internally without exposing. if we ever decide to expose it - we can follow up on this and address the issues raised.

Merge request reports