Skip to content

esm: avoid try/catch when validating urls

Rodrigo Muino Tomonari requested to merge github/fork/anonrig/improve-esm-performance into main

Due to URL.canParse, we can avoid try/catch block and have faster validation. The previous implementation was not performant due to:

  1. Unnecessary string serialization - We don't need href, origin etc. for validating if a URL is valid or not.
  2. URL.canParse can be written with V8 Fast API - enabling more performance out of this pull request.
  3. URL.canParse does not return anything except a boolean.

cc @nodejs/url

Merge request reports