Skip to content

esm: avoid accessing lazy getters for urls

Rodrigo Muino Tomonari requested to merge github/fork/anonrig/esm-improve-protocol into main

This pull request avoids multiple calls to the protocol getter of the URL. Previor to Ada version 2, url.protocol was always returned an already allocated string, but right now, it slices a new string for each call. Storing it in a variable and access it, would make some improvement in terms of performance.

cc @nodejs/url

Merge request reports