Skip to content

url: improve `isURL` detection

Rodrigo Muino Tomonari requested to merge url-fix-detection into main

Previously we were checking for protocol and origin attributes, but due to the lazy-loading nature of Ada 2.0 with url_aggregator we shifted from checking for origin. This was also breaking the detection of the legacy URL parse function. This PR fixes that in the least impactful way possible, by checking if auth property is defined.

Fixes https://github.com/nodejs/node/issues/47624

cc @nodejs/url @trott

Merge request reports