Skip to content

lib: reuse default DOMException in AbortController

Rodrigo Muino Tomonari requested to merge github/fork/debadree25/ft/abort-controller-lazy-exp into main

Similar to https://github.com/nodejs/node/pull/46086 have reused the default DOMException we throw when calling ac.abort(), so far the tests dont break and the benchmark added in this PR show good improvement

Benchmark results:

                                          confidence improvement accuracy (*)   (**)  (***)
events/abortcontroller-abort.js n=1000000        ***    148.36 %       ±2.47% ±3.30% ±4.33%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 1 comparisons, you can thus expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

Refs: https://github.com/nodejs/node/pull/46086 Refs: https://github.com/nodejs/performance/issues/44

Merge request reports