Skip to content

v8: isBuildingSnapshotBuffer out of bound fix

Rodrigo Muino Tomonari requested to merge github/fork/hemanth/patch-1 into main
❯ ./out/Release/node
node:internal/v8/startup_snapshot:22
  return isBuildingSnapshotBuffer[0];
                                 ^

TypeError: Cannot read properties of undefined (reading '0')
    at isBuildingSnapshot (node:internal/v8/startup_snapshot:22:34)
    at initializeGlobalConsole (node:internal/console/constructor:701:51)
    at patchProcessObject (node:internal/process/pre_execution:169:3)
    at prepareExecution (node:internal/process/pre_execution:64:3)
    at prepareMainThreadExecution (node:internal/process/pre_execution:42:3)
    at node: internal/main/repl:21:1

Node.js v21.0.0-pre

Was noticing this issue and fixing the array access made sense.

Merge request reports

Loading