Skip to content

Fix statically linking error against libopenssl.a

Rodrigo Muino Tomonari requested to merge github/fork/fabianbuettner/main into main

When statically linking against libopenssl.a there is a linking error e.g. when compiling node with CC="zig cc" and CXX="zig c++".

It looks like the ',' was mistakenly put inside the '-Wl,--whole-archive,' linker flag string, which means that the strings '-Wl,--whole-archive,' and '<(obj_dir)/deps/openssl/<(openssl_product)' will just get appended without a space character in between causing the linking step to fail.

Merge request reports

Loading