Skip to content

benchmark: fix tcp raw benchmarks after internal api change

Rodrigo Muino Tomonari requested to merge github/fork/yosuke-furukawa/fix/tcp-raw into v1.x

tcp raw benchmarks are broken. I got assertion failures when benchmark test is executed.

Assertion failed: ((object->InternalFieldCount()) > (0)), function Wrap, file ../src/util-inl.h, line 83.

I found the internal api changes on this commit (https://github.com/iojs/io.js/commit/819690fd983d61f90cdf05714a30782fe3b553cd). I think I fixed the benchmarks.

The result is here.

$ ./iojs benchmark/common.js net tcp
net/tcp-raw-c2s.js
net/tcp-raw-c2s.js len=102400 type=utf dur=5: 6
net/tcp-raw-c2s.js len=102400 type=asc dur=5: 11
net/tcp-raw-c2s.js len=102400 type=buf dur=5: 13
net/tcp-raw-c2s.js len=16777216 type=utf dur=5: 5
net/tcp-raw-c2s.js len=16777216 type=asc dur=5: 9
net/tcp-raw-c2s.js len=16777216 type=buf dur=5: 13

net/tcp-raw-pipe.js
net/tcp-raw-pipe.js len=102400 type=utf dur=5: 8
net/tcp-raw-pipe.js len=102400 type=asc dur=5: 11
net/tcp-raw-pipe.js len=102400 type=buf dur=5: 12
net/tcp-raw-pipe.js len=16777216 type=utf dur=5: 7
net/tcp-raw-pipe.js len=16777216 type=asc dur=5: 9
net/tcp-raw-pipe.js len=16777216 type=buf dur=5: 12

net/tcp-raw-s2c.js
net/tcp-raw-s2c.js len=102400 type=utf dur=5: 6
net/tcp-raw-s2c.js len=102400 type=asc dur=5: 11
net/tcp-raw-s2c.js len=102400 type=buf dur=5: 13
net/tcp-raw-s2c.js len=16777216 type=utf dur=5: 4
net/tcp-raw-s2c.js len=16777216 type=asc dur=5: 8
net/tcp-raw-s2c.js len=16777216 type=buf dur=5: 13

Merge request reports