Skip to content

deps: backport --predictable related changes to V8

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/predictable-bp into main

deps: V8: cherry-pick b33bf2dfd261

Original commit message:

Ignore --predictable when computing flag list hashes

This allows reproducible code cache generation.

Refs: https://github.com/nodejs/node/pull/48749

Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#88943}

Refs: https://github.com/v8/v8/commit/b33bf2dfd26131cd51640b618853f2dfcfe5f728

deps: V8: backport de9a5de2274f

Original commit message:

Ignore flags implied by --predictable during hash computation

https://chromium-review.googlesource.com/c/v8/v8/+/4681766 added
code to ignore --predictable during hash computation of flags
in order to produce reproducible code cache. This turns out to
be not enough since the flags implied by --predictable also
need to be ignored for it to work. This patch makes sure that
they are ignored.

Change-Id: Ifa36641efe3ca105706fd293be46fc974055d2d4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851287
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Patrick Thier <pthier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#90022}

Refs: https://github.com/v8/v8/commit/de9a5de2274f483961a04a933d84abd81dee9c07

Merge request reports