Skip to content

perf_hooks: reduce overhead of new performance_entries

Rodrigo Muino Tomonari requested to merge github/fork/H4ad/perf/perf_hooks into main

Continuing the work started on https://github.com/nodejs/performance/issues/109

Removed two references for ReflectConstruct, the improvements for createPerformanceNodeEntry can be seen using the timerfied function:

                                                    confidence improvement accuracy (*)    (**)   (***)
perf_hooks/timerfied.js observe='function' n=100000        ***    872.44 %      ±22.56% ±30.40% ±40.36%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 1 comparisons, you can thus
expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

The createPerformanceEntry is not used, should I remove it?

/cc @nodejs/performance

Merge request reports