Skip to content

lib: fix `primordials` typings

Rodrigo Muino Tomonari requested to merge github/fork/SamVerschueren/fix/primordials-type-definition into main

Hey 👋

I noticed that in the primordials.js, SymbolDispose and SymbolAsyncDispose are defined as

primordials.SymbolDispose ??= primordials.SymbolFor('nodejs.dispose');
primordials.SymbolAsyncDispose ??= primordials.SymbolFor('nodejs.asyncDispose');

The result of primordials.SymbolFor is a symbol. Currently these two properties are defined as SymbolConstructor (typeof Symbol). I think this is incorrect and should be updated to symbol instead.

Merge request reports